feat(gatsby-script): Inline scripts #35443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
tyhopp
added
topic: performance
…ess network waits
…et up network waits
12 tasks
tyhopp
added a commit
that referenced
this pull request
May 9, 2022
* feat(gatsby-script): Implement inline scripts * test(gatsby-script): Inline scripts unit tests * test(gatsby-script): Set up for e2e tests * test(gatsby-script): Display scripts with sources strategy * test(gatsby-script): dangerouslySetInnerHTML e2e tests * test(gatsby-script): Template literals e2e tests * chore(gatsby-script): Update package readme * chore(gatsby-script): Install latest canary to run in CI * chore(gatsby-script): Try waitForRouteChange to fix inconsistent Cypress network waits * chore(gatsby-script): Try delaying responses so Cypress has time to set up network waits * chore(gatsby-script): Try increasing network response delay even further * chore(gatsby-script): Remove unreliable Cypress network waits entirely
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inline script support for usage with
dangerouslySetInnerHTMLand template literals:All currently implemented strategies (
pre-hydrate,post-hydrate,idle) are supported.Todo
Documentation
Documentation will be added in a later PR.
Related Issues
[sc-48942]