[v2] Deprecate pathContext in favor of pageContext #3515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
calcsam
changed the title
KyleAMathews
changed the title
KyleAMathews
suggested changes
Jan 14, 2018
| contextKey = `layoutContext` | ||
| result[`layoutContext`] = pageOrLayout.context | ||
| } else { | ||
| result[`pathContext`] = pageOrLayout.context // deprecated! |
There was a problem hiding this comment.
I think we should just do a breaking change — this will mean loading the same data twice into the browser which could get expensive.
calcsam
force-pushed
the
deprecate-path-context-2
branch
from
6aee25f to
9659fa1
Compare
|
Changed this, going to merge into v2 branch. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching page context for path context to improve the API re: #1456