feat(gatsby-sharp): create more resilient wrapper around sharp #34339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
wardpeet
added
topic: media
wardpeet
commented
Dec 29, 2021
wardpeet
force-pushed
the
feat/gatsby-sharp
branch
2 times, most recently
from
22d303a to
128c5c8
Compare
wardpeet
changed the title
wardpeet
force-pushed
the
feat/gatsby-sharp
branch
5 times, most recently
from
57fe17f to
696d197
Compare
wardpeet
commented
Jan 12, 2022
Comment on lines
+5
to
+11
| babelrcRoots: [ | ||
| // Keep the root as a root | ||
| `.`, | ||
|
|
||
| // Also consider monorepo packages "root" and load their .babelrc files. | ||
| `./packages/*`, | ||
| ], |
There was a problem hiding this comment.
This allows jest to use the babelrc inside a package instead of only the global one.
wardpeet
force-pushed
the
feat/gatsby-sharp
branch
from
b75af7b to
19ca39f
Compare
LekoArts
reviewed
Jan 17, 2022
LekoArts
previously approved these changes
Jan 17, 2022
wardpeet
commented
Jan 17, 2022
LekoArts
approved these changes
Jan 17, 2022
This was referenced Jan 26, 2022
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a new package that wraps sharp and is 100% async. When sharp throws an error when we requiring it, we will rebuild sharp once to see if that fixes the issue. Sharp broken binary is one of the error most people hit. This happens when people switch between os architectures (Windows, WSL, M1, Rosetta, ...)
This is helpful as we will be importing sharp into Gatsby by default so we want to be as resilient as possible.