fix(gatsby-plugin-image): Image flickering (reloading unnecessarily) #32899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
graysonhicks
approved these changes
Sep 30, 2021
|
Can we get this merged soon? Still experiencing lots of flickering issues with the new gatsby plugin image |
LekoArts
added
topic: media
LekoArts
changed the title
|
Hey, Thanks for the PR but it doesn't 100% fix it at the right place. This one does #33732. Thank you for waiting and your PR! We really appreciate the work you put in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems like there are situations that cause the
isLoadedstatus to be rechecked which causes the image to fade back in even though it's already loaded.There is some discussion here where it happens after a page load: #32037
...which is also where this fix comes from, thanks to @plainice
My team experienced this not right after a page load, but when we adjusted the height of a DOM element that contained images using gatsby-image-plugin.