fix(gatsby): handle errors thrown when importing html renderer #32417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
pieh
added
topic: core
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here |
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here |
LekoArts
approved these changes
Jul 19, 2021
pieh
added
the
bot: merge on green
LekoArts
pushed a commit
that referenced
this pull request
Jul 19, 2021
(cherry picked from commit b6f1272)
LekoArts
pushed a commit
that referenced
this pull request
Jul 19, 2021
… (#32423) (cherry picked from commit b6f1272) Co-authored-by: Michal Piechowiak <[email protected]>
This was referenced Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extra error details added in #32301 assume that all errors will have
.context.path. But errors can be not specific to any particular page and can be thrown when just importing html rendering bundle (example of such error would be https://github.com/gatsbyjs/gatsby/blob/a0b542be35c15e71f8fe76cc5400576dfd0b1391/integration-tests/gatsby-cli/gatsby-sites/gatsby-build-errors/src/pages/index.js)