fix(gatsby-telemetry): Read installedGatsbyVersion correctly for workspaces #31196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
force-pushed
the
jarmo/ch30087/understand-why-so-many-machines-are-logged
branch
from
338ba86
to
f514204
Compare
|
I released this as We would need to backport this to v2 to get the widest distribution of this hotfix. |
pieh
reviewed
May 3, 2021
|
Seems that |
LekoArts
added
topic: telemetry*
and removed
status: triage needed
pieh
pushed a commit
that referenced
this pull request
May 4, 2021
…spaces (#31196) * Read Gatsby version correctly * Simplify logic Co-authored-by: Jarmo Isotalo <[email protected]> (cherry picked from commit af12b66)
pieh
pushed a commit
that referenced
this pull request
May 4, 2021
…spaces (#31196) (#31208) * Read Gatsby version correctly * Simplify logic Co-authored-by: Jarmo Isotalo <[email protected]> (cherry picked from commit af12b66) Co-authored-by: Sidhartha Chatterjee <[email protected]>
vladar
pushed a commit
that referenced
this pull request
May 4, 2021
…spaces (#31196) * Read Gatsby version correctly * Simplify logic Co-authored-by: Jarmo Isotalo <[email protected]> (cherry picked from commit af12b66)
vladar
pushed a commit
that referenced
this pull request
May 4, 2021
…spaces (#31196) (#31244) * Read Gatsby version correctly * Simplify logic Co-authored-by: Jarmo Isotalo <[email protected]> (cherry picked from commit af12b66) Co-authored-by: Sidhartha Chatterjee <[email protected]>
|
Published in |
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For yarn workspaces (when
process.cwd()) is not the parent directory wherenode_modulesincludesgatsby, the current code is unable to read the installed gatsby version. This attempts to fix that.Remember that
mainfor thegatsbypackage iscache-dir/commonjs/gatsby-browser-entry.jsso we need to strip out three segments to be able to resolve to rootCo drafted with the wonderful @jamo