Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-netlify-cms): align mini-css-extract-plugin version #31093

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

erezrokah
Copy link
Contributor

Description

TLDR: having mismatching versions of mini-css-extract-plugin in Gatsby and the Netlify CMS plugin causes build errors.
In Gatsby v3 this was fixed by aligning the versions, but the fix was not back ported to v2.

This PR ports back the fix to a branch named gatsby-plugin-netlify-cms_v4 which is based on the tag [email protected]. I believe v4.10.0 is the last non v5 release of the plugin.

To fix the issue for Gatsby v2 users, we'll need to merge this PR and release a new version of the plugin based on the gatsby-plugin-netlify-cms_v4 branch (probably [email protected]).

Related Issues

Fixes #24577 for Gatsby v2 users per #24577 (comment) and #24577 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 28, 2021
@pieh pieh self-assigned this Apr 28, 2021
@pieh
Copy link
Contributor

pieh commented Apr 28, 2021

Yeah, it make sense 👍

This PR ports back the fix to a branch named gatsby-plugin-netlify-cms_v4 which is based on the tag [email protected]. I believe v4.10.0 is the last non v5 release of the plugin.

Can you target release/2.32 branch instead (and possibly cover any lock file adjustments if needed)? I would have to eventually get this change to that branch anyway to make actual release for previous major (just due to our publishing setup with lerna)

@LekoArts LekoArts added topic: netlify and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 29, 2021
@erezrokah erezrokah changed the base branch from gatsby-plugin-netlify-cms_v4 to release/2.32 April 29, 2021 08:11
@erezrokah erezrokah closed this Apr 29, 2021
@erezrokah erezrokah force-pushed the fix/align_min_css_version branch from 9550fdb to 83c26f8 Compare April 29, 2021 08:11
@erezrokah erezrokah deleted the fix/align_min_css_version branch April 29, 2021 08:12
@erezrokah erezrokah restored the fix/align_min_css_version branch April 29, 2021 08:12
@erezrokah erezrokah deleted the fix/align_min_css_version branch April 29, 2021 08:13
@erezrokah erezrokah reopened this Apr 29, 2021
@erezrokah
Copy link
Contributor Author

Can you target release/2.32 branch instead

Sure, changing the base kind of messed with GitHub, but this should be ok now.

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pieh pieh merged commit 9095266 into release/2.32 Apr 29, 2021
@pieh
Copy link
Contributor

pieh commented Apr 29, 2021

[email protected] was published

@Morantron
Copy link

thanks <3

@jf-home
Copy link

jf-home commented May 7, 2021

This doesn't appear to resolve the issue for me. I'm still getting the following error:

gatsby-plugin-purgecss: Only processing  C:\home\hello-i8n\src\components\all.sass
⠋ Building development bundle
C:\home\hello-i8n\node_modules\yoga-layout-prebuilt\yoga-layout\build\Release\nbind.js:53
        throw ex;
        ^

Error: Callback was already called.
    at throwError (C:\home\hello-i8n\node_modules\neo-async\async.js:16:11)
    at C:\home\hello-i8n\node_modules\neo-async\async.js:2818:7
    at processTicksAndRejections (internal/process/task_queues.js:75:11)

@erezrokah
Copy link
Contributor Author

erezrokah commented May 9, 2021

Hi @jf-home can you post a reproduction on the issue #24577?
Please share a pubic repo reproducing the error and the result of npm ls gatsby-plugin-netlify-cms or yarn why gatsby-plugin-netlify-cms

@jf-home
Copy link

jf-home commented May 14, 2021

Hi @erezrokah - absolutely - comment added to #24577 as requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants