-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-netlify-cms): align mini-css-extract-plugin version #31093
Conversation
Yeah, it make sense 👍
Can you target |
9550fdb
to
83c26f8
Compare
Sure, changing the base kind of messed with GitHub, but this should be ok now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
thanks <3 |
This doesn't appear to resolve the issue for me. I'm still getting the following error:
|
Hi @erezrokah - absolutely - comment added to #24577 as requested. |
Description
TLDR: having mismatching versions of
mini-css-extract-plugin
in Gatsby and the Netlify CMS plugin causes build errors.In Gatsby v3 this was fixed by aligning the versions, but the fix was not back ported to v2.
This PR ports back the fix to a branch named
gatsby-plugin-netlify-cms_v4
which is based on the tag[email protected]
. I believev4.10.0
is the last non v5 release of the plugin.To fix the issue for Gatsby v2 users, we'll need to merge this PR and release a new version of the plugin based on the
gatsby-plugin-netlify-cms_v4
branch (probably[email protected]
).Related Issues
Fixes #24577 for Gatsby v2 users per #24577 (comment) and #24577 (comment)