fix(gatsby): handle plugin path resolution in resolvePlugin function #30812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: plugins
vladar
approved these changes
Apr 12, 2021
moonmeister
added a commit
that referenced
this pull request
Apr 14, 2021
* master: (183 commits) chore(gatsby-plugin-image): Remove version note (#30758) docs: retire 'How to Create Pages' stub and Recipes landing page (#30842) chore(docs): Fix typo (#30858) docs: fix invalid mailto links in 3.3 release notes (#30862) docs: release notes for 3.3 (#30837) fix(gatsby-source-wordpress): invalidate less queries during previews (#30770) fix(gatsby-starter-wordpress-blog): Fix altText (#30832) feat(contentful): warn users when using restricted content type names (#30715) Refactor: using-contentful to use gatsby-plugin-image exclusively (#30717) chore(gatsby-plugin-styled-components): Remove breaking changes section (#30806) fix(gatsby): webpack warnings are no longer in object format by default (#30801) fix(gatsby): Decode base path in runtime (#30682) fix(gatsby): "Cannot find module 'babel-preset-gatsby'" error (#30813) handle plugin parentDir resolution in resolvePlugin() (#30812) Port using-gatsby-image site to image plugin (#28489) fix(gatsby-source-contentful): De-dupe type names (#30834) feat(gatsby): Add aggregation resolvers (#30789) fix(gatsby-core-utils): fetch-remote-file download failure when missing content-length header (#30810) fix(renovate): add breaking minor updates to major updates list (#30676) chore(docs): Update migration guide for plugins that support both v2 & v3 (#30825) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the plugin
rootDir<->parentDirresolution into theresolvePlugin()function, instead of relying on callers to set the correctrootDirPR #29787 broke pnpm/yarn2 because it reused
resolvePlugin()in order to resolve a plugin's details, but didn't respect theparentDirproperty set on the plugin objects. By moving that path resolution inside of the function and documenting that the plugin object should be the preferred parameter, hopefully this can be avoided in the future?Related Issues
Related to PR #29787