Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-image): Allow draggable=false on images #30754

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Apr 8, 2021

Setting all: inherit on img was causing issues with props not being applied to the element. The specific bug is #30666, which is where draggable is not being applied. I'm not sure why we needed this rule in the first place, but it seems to work fine without it.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 8, 2021
@ascorbic ascorbic added topic: media Related to gatsby-plugin-image, or general image/media processing topics and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 8, 2021
@ascorbic ascorbic changed the title fix(gatsby-plugin-image): All draggable=false on images fix(gatsby-plugin-image): Allow draggable=false on images Apr 8, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, there's no regression regarding #28317 with this, right?

@ascorbic ascorbic merged commit 1a9b830 into master Apr 8, 2021
@ascorbic ascorbic deleted the fix/image-inherit branch April 8, 2021 15:09
This was referenced Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: media Related to gatsby-plugin-image, or general image/media processing topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants