Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: isolate tests to tmp directory #30646

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Apr 2, 2021

Description

When doing e2e-tests or integration tests, isolate the projects to tmp so it can't take any modules from the monorepo.

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Apr 2, 2021
@LekoArts LekoArts added topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Apr 6, 2021
@wardpeet wardpeet force-pushed the fix/isolate-integration branch 4 times, most recently from 6a26cd7 to 47805c5 Compare April 23, 2021 09:24
@wardpeet wardpeet force-pushed the fix/isolate-integration branch 2 times, most recently from d654f0b to 4926c4b Compare April 29, 2021 07:16
@wardpeet wardpeet force-pushed the fix/isolate-integration branch from 4926c4b to c564fdf Compare April 29, 2021 09:39
@wardpeet wardpeet marked this pull request as ready for review April 29, 2021 10:52
path.join(__dirname, "../src/pages/"),
{
overwrite: true,
}
Copy link
Contributor Author

@wardpeet wardpeet Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have a git repo anymore in TMP so we can't use git checkout.

scripts/e2e-test.sh Outdated Show resolved Hide resolved
@wardpeet wardpeet merged commit 1527e47 into master Apr 29, 2021
@wardpeet wardpeet deleted the fix/isolate-integration branch April 29, 2021 15:55
vladar pushed a commit that referenced this pull request May 4, 2021
vladar added a commit that referenced this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants