Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update default & blog starter to v3 #29919

Merged
merged 5 commits into from
Mar 2, 2021
Merged

chore: Update default & blog starter to v3 #29919

merged 5 commits into from
Mar 2, 2021

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Mar 2, 2021 •
edited
Loading

Description

  • Change README to include link to cloud
  • Add "Live Preview" to README
  • Change React imports to preferred syntax
  • Use StaticImage
  • blog
    • comment out google-analytics as it would fail otherwise
    • change feed plugin so that it works

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Mar 2, 2021
@LekoArts LekoArts added topic: starters and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Mar 2, 2021
laurieontech
laurieontech approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling this!

ascorbic
ascorbic approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@LekoArts LekoArts merged commit ec8c43e into master Mar 2, 2021
@LekoArts LekoArts deleted the v3/update-main-starters branch March 2, 2021 14:51
wardpeet
wardpeet approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, do we want to enable avif by default?

@LekoArts
Copy link
Contributor Author

LekoArts commented Mar 2, 2021

@wardpeet yeah, AVIF is a good idea. I'll open a follow-up PR.

@LekoArts LekoArts mentioned this pull request Mar 2, 2021
Merged
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
chore: Update default & blog starter to v3 (gatsbyjs#29919)
5b30c3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurieontech laurieontech laurieontech approved these changes

@wardpeet wardpeet wardpeet approved these changes

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LekoArts @ascorbic @wardpeet @laurieontech