docs (gatsby-plugin-image): Remove filesystem from config #29802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
laurieontech
added
status: needs docs review
added 2 commits
February 26, 2021 09:04
ascorbic
reviewed
Feb 26, 2021
| `gatsby-transformer-sharp`, | ||
| ], | ||
| } | ||
| ``` | ||
|
|
||
| If you already have some of these plugins installed, please check that they're updated to the latest version. | ||
|
|
||
| Note that `gatsby-source-filesystem` is not included in this config. If you are sourcing from your local filesystem to use `GatsbyImage` please configure accordingly. Otherwise, downloading the dependency without configuration is sufficient. | ||
|
|
There was a problem hiding this comment.
Is this going to be confusing?
There was a problem hiding this comment.
My instinct is that we have to say something? And having them configure it for an arbitrary folder they aren't sourcing seems unhelpful.
There was a problem hiding this comment.
cc: @meganesu Would love your take on this. Either way we need to change the existing config, so should figure out which option is the most helpful.
ascorbic
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought we'd already made this change, but making it now. This is an invalid config.