Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-sharp): decode URL so it matches the cache key #28449

Merged
merged 1 commit into from
Dec 3, 2020
Merged

fix(gatsby-plugin-sharp): decode URL so it matches the cache key #28449

merged 1 commit into from
Dec 3, 2020

Conversation

KyleAMathews
Copy link
Contributor

Found this on my blog. Also reported in the umbrella issue #27603 (comment)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Dec 2, 2020
@KyleAMathews KyleAMathews requested a review from vladar December 2, 2020 21:42
@KyleAMathews KyleAMathews added topic: sharp and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Dec 2, 2020
pvdz
pvdz previously requested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@pvdz pvdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test case that tests a url that doesn't need this (should already be there, I hope?) and a url that does need it?

vladar
vladar approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvdz We don't have tests for this experiment yet. But I took over this feature and will be working on adding tests in separate PRs.

This PR is good to go as-is (as for me).

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Dec 3, 2020
@KyleAMathews KyleAMathews merged commit 946eed0 into master Dec 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the decode-url branch December 3, 2020 15:10
pieh pushed a commit that referenced this pull request Dec 4, 2020
@KyleAMathews @pieh
fix(gatsby-plugin-sharp): decode URL so it matches the cache key (#28449
f7ac2cd 
)

(cherry picked from commit 946eed0)
@gatsbybot gatsbybot mentioned this pull request Dec 4, 2020
Merged
pieh pushed a commit that referenced this pull request Dec 4, 2020
@KyleAMathews @pieh
fix(gatsby-plugin-sharp): decode URL so it matches the cache key (#28449
74dcb13 
)

(cherry picked from commit 946eed0)
pieh pushed a commit that referenced this pull request Dec 4, 2020
@KyleAMathews
fix(gatsby-plugin-sharp): decode URL so it matches the cache key (#28449
0119789 
) (#28479)

(cherry picked from commit 946eed0)

Co-authored-by: Kyle Mathews <[email protected]>
@pieh
Copy link
Contributor

pieh commented Dec 7, 2020

Published [email protected]

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
@gatsbybot
fix(gatsby-plugin-sharp): decode URL so it matches the cache key (gat…
d06bb08 
…sbyjs#28449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

@vladar vladar vladar approved these changes

@pvdz pvdz pvdz left review comments

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KyleAMathews @pieh @vladar @pvdz @ascorbic