Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(gatsby-plugin-sharp): update dependencies #26826

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Sep 8, 2020

Description

Reverts the upgrades of imagemin plugins.

Testing can be done with yarn add gatsby-plugin-sharp@png-revert --registry=https://registry.wardpeet.dev

Related Issues

#26723

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 8, 2020
@pvdz pvdz added topic: npm* and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 8, 2020
@ascorbic
Copy link
Contributor

ascorbic commented Sep 8, 2020

I can confirm this fixes the repro that I had yesterday

@hoobdeebla
Copy link
Contributor

I submitted the original PR to update the dependencies. My bad for not digging deep enough into its side effects.

If imagemin/imagemin-pngquant#71 is merged then we can just bump it to ^9.0.1 instead of reverting every update like we do here. That would also fix #26723. Hopefully it gets merged soon.

@wardpeet wardpeet merged commit 05474e3 into gatsbyjs:master Sep 8, 2020
@wardpeet wardpeet deleted the revert/update-dependencies branch September 8, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants