Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): only enable debugger when argument is given #26669

Merged
merged 2 commits into from
Aug 31, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Aug 27, 2020

Description

Default arguments in yargs caused to always run node debugger when gatsby develop was run. This fixes it.
image

Documentation

Related Issues

Fixes #26708

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 27, 2020
@pieh pieh self-assigned this Aug 28, 2020
@pieh pieh added topic: dev tooling and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 28, 2020
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈 thank you for this, just one minor problem to solve here :)

packages/gatsby/src/commands/develop.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS Code debugger broken (Exception: Inspector is already activated)
2 participants