[gatsby-source-wordpress] Refactored featured_media map for deep nodes #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Featured medias coul be nested at any level * The most certain way to have photos works with this version on the plugin is to either name the fiel featured_media or include the image as Post Object. * Fixed bug where in some case the old featured_media field was not deleted.
|
Deploy preview ready! Built with commit e286a25 |
sebastienfi
changed the title
|
Funny enough pieh has been working on something similar with this PR #2646 I believe my PR is more generic as it allows for featured_medias to be placed anywhere in the JSON tree, let's say for example, in a linked Post Object. |
|
haha, brilliant minds… I'll let you make the call on which one to merge. |
|
It's nobrainer that You should take Your code, as most likely You will maintain it ;) Just check my comment #2646 (comment) and I think You can close my PR and focus on this one. |
* Most of the credits goes to @pieh for a better solution that solved the same problems and widely improved code simplicity. #2646 * Made the Media lookup begin at JSON tree root instead of keeping this for ACF Field only. Changed constants names accordingly. * Making thise more generic allorws Custom Post Types to benefit from this improvements and yet unseen objects shapes. * Incorporated fix on bug mentionned here #2646 (comment) * May solve this #2587, this #2492, this #2328
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with using-wordpress OK.