Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): query filters -> update dictionary, code fences, fix code, brand name #26408

Merged
merged 6 commits into from
Aug 31, 2020
Merged

fix(docs): query filters -> update dictionary, code fences, fix code, brand name #26408

merged 6 commits into from
Aug 31, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Aug 12, 2020 •
edited
Loading

Description

changes:

  • remove unused sift words from dictionary (extractFieldsToSift, siftified,siftifyArgs)
  • remove capitalized word from dictionary (Comparator since comparator include both ones)
  • put filterValue in code fences so it can removed from dictionary
  • brand name sift.js to Sift
  • add curly brace } to code snippet
  • changed case of node/file (because other nodes are in lowercase in the doc)

Related Issues

@muescha muescha requested a review from a team as a code owner August 12, 2020 15:52
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 12, 2020
@muescha
Copy link
Contributor Author

muescha commented Aug 12, 2020 •
edited
Loading

FYI: the lint:other forced me to have the code change 2644bd7 of the inline example data with prettier (i guess in the PR before it not failed because of wrong javascript with missing brackets)

@vladar vladar added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 14, 2020
LekoArts
LekoArts approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit fed2619 into gatsbyjs:master Aug 31, 2020
@muescha muescha deleted the muescha/fix/query-filter branch August 31, 2020 18:43
This was referenced Apr 7, 2022
Open
Open
@nidhi42 nidhi42 mentioned this pull request Jan 30, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LekoArts LekoArts LekoArts approved these changes

Assignees
No one assigned
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muescha @LekoArts @vladar