docs(gatsby-image): Deprecate sizes and resolutions props
#26309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users are still using these props accidentally due to their visibility in guides.
gatsbot
bot
added
the
status: triage needed
blainekasten
approved these changes
Aug 10, 2020
blainekasten
added
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some users are still using these props accidentally due to their visibility in guides.
For context, these two props were deprecated once v2 arrived.
Related Issues
My old PR: 844a496#r285505388
Originally during review this was pointed out if it should also log deprecation notices for these two props, but it was resolved and merged without a response. I've included that in this PR in the event I've missed some other old docs, or users try following dated third-party guides for some reason.