Admin/recipes gui #26243
Admin/recipes gui #26243
Conversation
gatsbot
bot
added
the
status: triage needed
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 20s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 23m |
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 35m PerformanceLighthouse report
|
pieh
added
topic: recipes
and removed
status: triage needed
|
|
||
| return ( | ||
| <> | ||
| <Styled.p>{` `}</Styled.p> |
There was a problem hiding this comment.
NB: I don't think a <p> is needed here, a <div> with margin could create visual space
There was a problem hiding this comment.
There is also a <Spacer /> component in gatsby-interface that I use for these kinds of purposes!
packages/gatsby-admin/src/components/recipes-gui/recipe-step.js
Outdated
Show resolved
Hide resolved
| /** @jsx jsx */ | ||
| /* eslint-disable */ | ||
| import React from "react" | ||
| import { MdRefresh, MdBrightness1 } from "react-icons/md" |
There was a problem hiding this comment.
NB: I think the react-icons library has been updated since I've used it, but I assume this doesn't include the entire set of MD icons in the bundle
| if (state.value === `applyingPlan` && resource.isDone) { | ||
| icon = <SuccessIcon /> | ||
| } else if (state.value === `applyingPlan`) { | ||
| const keyframe = keyframes` |
There was a problem hiding this comment.
Nitpick: I don't know how emotion works, but I do know that in styled-components we recommend moving keyframes declarations out of the render method. There is no need for this to be re-created every render! 👍
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable */ | |||
There was a problem hiding this comment.
Is there a particular reason we disable eslint for this file? 🤔
| @@ -8,10 +9,12 @@ import { SubscriptionClient } from "subscriptions-transport-ws" | |||
|
|
|||
| interface ICreateUrqlClientOptions { | |||
| port: number | |||
| connectionCallback: any | |||
There was a problem hiding this comment.
Nit: no need for this any!
import { SubscriptionClient, ClientOptions } from "subscriptions-transport-ws"
interface ICreateUrqlClientOptions {
port: number
connectionCallback: ClientOptions["connectionCallback"]
}…into admin/recipes-gui
Move recipes GUI into admin and refactor it to remove tech debt and client-side weight. Make use of new service lock metadata to grab project root.
Things out of scope:
Not ready for merge: CLI bug needs fixing