chore(gatsby-plugin-mdx): Revert "perf(gatsby-plugin-mdx): performance changes" #26202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e02abe.
gatsbot
bot
added
the
status: triage needed
pvdz
added
topic: MDX
topic: performance
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21s PerformanceLighthouse report
|
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 21s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 1m PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 27s PerformanceLighthouse report
|
pvdz
added
the
bot: merge on green
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 22m |
|
Published in [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #26004
Fixes #25734
Before the exports would be gathered through our custom babel plugin
babel-plugin-gather-exports. It would visit all named exports, attempt toJSON.parsetheir init, and if that worked record it. It would ignore cases where this doesn't works. These cases are then returned as an object.Next step comes
babel-plugin-remove-export-keywords, which would take these named exports likeexport const foo = randomExpression();and drop the keyword toconst foo = randomExpression();. This works because theexportkeyword doesn't really change anything for the declaration. Only meta stuff. So the module itself works the same either way.Since we bypass the babel step the exports are no longer
JSON.parse()ed and so the frontmatter object is not found.At this point there are too many pointy edges in this part that I'm going to concede and leave it as is. Stripping the babel step is worth it but it needs a lot more tests and some thorough rewrites in mdx itself before we test this again. Luckily v2 is on the horizon.