Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby-plugin-mdx): Upgrade MDX and snapshots #26143

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

johno
Copy link
Contributor

@johno johno commented Jul 30, 2020

Starting in MDX version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is now bumped to 1.6.16 with the snapshots
updated.

Related:

@johno johno requested a review from a team as a code owner July 30, 2020 16:43
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

client-only-paths

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 🔶 85
Best Practices 💚 100
SEO 🔶 70

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

using-styled-components

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 90
Best Practices 💚 100
SEO 💚 90

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

using-reach-skip-nav

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 82

🔗 View full report

@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 30, 2020

Gatsby Cloud Build Report

gatsby-master

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 💚 96
Accessibility 🔶 87
Best Practices 💚 93
SEO 🔶 73

🔗 View full report

@johno johno removed the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 30, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Jul 30, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

Starting in version 1.6.16, the makeShortcode function
is only added to compiled MDX when it is needed. This
caused the gatsby-plugin-mdx snapshots to fall out of
date. MDX is no bumped to 1.6.16 with the snapshots
updated.

Related:

- #24595 (comment)
- mdx-js/mdx#1088
@johno johno force-pushed the mdx-shortcode-snapshot branch from d2793f9 to 6eccc6b Compare July 30, 2020 17:07
@gatsby-cloud-staging
Copy link

gatsby-cloud-staging bot commented Jul 30, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 5m

Performance

Lighthouse report

Metric Score
Performance 💚 93
Accessibility 💚 100
Best Practices 💚 100
SEO 🔶 76

🔗 View full report

Copy link
Contributor

@laurieontech laurieontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@johno johno added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 30, 2020
@gatsbybot gatsbybot merged commit d421cf8 into master Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the mdx-shortcode-snapshot branch July 30, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants