Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Update deploying-to-netlify #25620

Merged
merged 2 commits into from
Oct 5, 2020
Merged

chore(docs): Update deploying-to-netlify #25620

merged 2 commits into from
Oct 5, 2020

Conversation

jackpeplinski
Copy link
Contributor

Description

  • move "Continuous deployment" under "Git repository setup" because continuous deployment is only possible with a Git repository
  • add secondary default branch for deployment as main

move "Continuous deployment" under "Git repository setup" because continuous deployment is only possible with a Git repository

add secondary default branch for deployment as `main`
@jackpeplinski jackpeplinski requested a review from a team as a code owner July 8, 2020 19:18
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 8, 2020
@pieh pieh added status: needs docs review Pull request related to documentation waiting for review and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jul 9, 2020
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'm curious where you got the part about "secondary default is main". I know there's been a movement toward renaming the master branch in Git, is that reflected in Netlify's docs somewhere?

@marcysutton marcysutton added type: documentation An issue or pull request for improving or updating Gatsby's documentation status: awaiting author response Additional information has been requested from the author and removed status: needs docs review Pull request related to documentation waiting for review labels Jul 16, 2020
@jackpeplinski
Copy link
Contributor Author

jackpeplinski commented Jul 21, 2020

Hi! I couldn't find an article specifically referencing that the "secondary default is main". When working on a project, I had a main and master branch when transition to main.

Once I deleted the master branch, main was used even though I still had other branches on the project.

This made me assume that the "secondary default is main".

The closest thing I could find was here.

@marcysutton

Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd revert the change to the branch and then we can merge :)

@@ -27,13 +27,17 @@ Netlify currently has built in support for [GitHub](https://github.com/), [GitLa

Now, login to Netlify and you will see a `New site from git` button at the top right corner of the screen. Click on it and connect with the same git provider that you used to host your website and authorize Netlify to use your account. Choose your website repository and it will take you to deploy settings with the below options.

- Branch to deploy: You can specify a branch to monitor. When you push to that particular branch, only then will Netlify build and deploy the site. The default is `master`.
- Branch to deploy: You can specify a branch to monitor. When you push to that particular branch, only then will Netlify build and deploy the site. The default is `master`. The secondary default is `main`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert that change as this isn't documented by Netlify and I assume this just happened to you because the main branch became the default branch by deleting master and thus Netlify takes the default one.

@LekoArts LekoArts changed the title update deploying-to-netlify.md chore(docs): Update deploying-to-netlify Sep 4, 2020
@LekoArts LekoArts merged commit 52c69bd into gatsbyjs:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author type: documentation An issue or pull request for improving or updating Gatsby's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants