Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(docs): dictionary.txt -> Infer* -> putting all code prefixed with infer into code blocks #25339

Merged
merged 12 commits into from
Jul 3, 2020
Merged

Conversation

FocalChord
Copy link
Contributor

Description

In this PR we reference issue #25290 where they have asked to: put code like inferInputObjectStrctureFromNodes in code blocks. I have identified there are a few more cases of these code which I have also taken care of.

We do this by finding all instances of all strings prefixed with infer[X] that are not in code blocks yet and then add a code block around them. I then remove all of those strings from the dictionary.

Documentation

No documentation is required for this

Related Issues

Partially addresses #25290

@FocalChord FocalChord requested review from a team as code owners June 26, 2020 22:30
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jun 26, 2020
@muescha muescha changed the title enhancement(docs): dictionary.txt -> putting all code prefixed with Infer into code blocks enhancement(docs): dictionary.txt -> Infer* -> putting all code prefixed with infer into code blocks Jun 27, 2020
@pvdz pvdz added status: needs docs review Pull request related to documentation waiting for review type: dx and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Jun 30, 2020
Copy link
Contributor

@tesseralis tesseralis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thank you!

@tesseralis tesseralis merged commit 88cfa77 into gatsbyjs:master Jul 3, 2020
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
…xed with infer into code blocks (gatsbyjs#25339)

* putting inferInputObjectStructureFromNodes into code block

* removing inferInputObjectStructureFromNodes from dictionary.txt file

* putting inferInputObjectStructureFromFields into code block

* removing inferInputObjectStructureFromFields from dictionary.txt file

* putting inferObjectStructureFromNodes into code block

* removing inferObjectStructureFromNodes from dictionary.txt file

* putting inferFromFieldName into code block

* removing inferFromFieldName from dictionary.txt file

* putting inferFromMapping into code block

* removing inferFromMapping from dictionary.txt file

* putting inferGraphQLType into code block

* removing inferGraphQLType from dictionary.txt file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs docs review Pull request related to documentation waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants