-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement(docs): dictionary.txt -> Infer* -> putting all code prefixed with infer into code blocks #25339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
tesseralis
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thank you!
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
…xed with infer into code blocks (gatsbyjs#25339) * putting inferInputObjectStructureFromNodes into code block * removing inferInputObjectStructureFromNodes from dictionary.txt file * putting inferInputObjectStructureFromFields into code block * removing inferInputObjectStructureFromFields from dictionary.txt file * putting inferObjectStructureFromNodes into code block * removing inferObjectStructureFromNodes from dictionary.txt file * putting inferFromFieldName into code block * removing inferFromFieldName from dictionary.txt file * putting inferFromMapping into code block * removing inferFromMapping from dictionary.txt file * putting inferGraphQLType into code block * removing inferGraphQLType from dictionary.txt file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we reference issue #25290 where they have asked to: put code like inferInputObjectStrctureFromNodes in code blocks. I have identified there are a few more cases of these code which I have also taken care of.
We do this by finding all instances of all strings prefixed with infer[X] that are not in code blocks yet and then add a code block around them. I then remove all of those strings from the dictionary.
Documentation
No documentation is required for this
Related Issues
Partially addresses #25290