refactor(websocket): unify page-data emitting #25190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
approved these changes
Jun 22, 2020
sidharthachatterjee
added
bot: merge on green
delete-merged-branch
bot
deleted the
query-modules/unify-page-data-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes our websocket manager to emit full body of
page-dataand not just query results + streamlines what we pass toemitPageData.This change on its own it's not doing much, it's just preparation to pass
page-dataemitted by websocket to run throughloaderto make sure we load modules that could have been added as a result of query runningRelated Issues
Tracking PR for data-driven code-splitting - #24903