Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add form-name hidden field for Netlify Forms #24548

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

veth-tech
Copy link
Contributor

Description

  1. Added name attribute to form element.
  2. Added hidden input field with form-name

It appears that Gatsby strips the form name from the form submission. By adding the hidden field you can restore the name and don't run into submission issues with Netlify.

Documentation

Netlify Docs showing hidden field -> https://www.netlify.com/blog/2017/07/20/how-to-integrate-netlifys-form-handling-in-a-react-app/#step-2
Example code from -> https://codebushi.com/form-handling-gatsby-netlify/

Related Issues

Other have run into this issue at -> #12040

It appears that Gatsby strips the form name from the form submission. By adding the hidden field you can restore the name and don't run into submission issues. 
Example code from -> https://codebushi.com/form-handling-gatsby-netlify/
Other have run into this issue at -> gatsbyjs#12040
@veth-tech veth-tech requested a review from a team as a code owner May 27, 2020 20:18
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 27, 2020
@anishagg17 anishagg17 added topic: a11y Related to accessibility topic: i18n and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 27, 2020
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, makes sense to me! I already had that on my own site which uses Netlify Forms–so it does work.

@marcysutton marcysutton merged commit de1db4b into gatsbyjs:master Jun 5, 2020
@gatsbot
Copy link

gatsbot bot commented Jun 5, 2020

Holy buckets, @veth-tech — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
It appears that Gatsby strips the form name from the form submission. By adding the hidden field you can restore the name and don't run into submission issues.
Example code from -> https://codebushi.com/form-handling-gatsby-netlify/
Other have run into this issue at -> gatsbyjs#12040

Co-authored-by: gatsbybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: a11y Related to accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants