Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gatsby): Migrate reducers/nodes-by-type to TypeScript #24419

Merged
merged 6 commits into from
May 26, 2020
Merged

chore(gatsby): Migrate reducers/nodes-by-type to TypeScript #24419

merged 6 commits into from
May 26, 2020

Conversation

alisson-suzigan
Copy link
Contributor

Description

This PR converts the following files to TS:

  • packages/gatsby/src/redux/reducers/nodes-by-type.ts

Related Issue

Related to #21995

@alisson-suzigan alisson-suzigan requested a review from a team as a code owner May 24, 2020 19:53
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 24, 2020
@alisson-suzigan alisson-suzigan self-assigned this May 24, 2020
@blainekasten blainekasten mentioned this pull request May 24, 2020
Closed
@LekoArts LekoArts added type: TypeScript migration and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 25, 2020
@pieh pieh self-assigned this May 26, 2020
pieh
pieh previously requested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great - just small cleanup on left out commented out old code and we can get this in :)

packages/gatsby/src/redux/reducers/nodes-by-type.ts Outdated Show resolved Hide resolved
blainekasten
blainekasten approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label May 26, 2020
@gatsbybot gatsbybot merged commit 1c5580a into gatsbyjs:master May 26, 2020
johno pushed a commit to johno/gatsby that referenced this pull request May 28, 2020
@alisson-suzigan @pieh
@blainekasten @johno
chore(gatsby): Migrate reducers/nodes-by-type to TypeScript (gatsbyjs…
c9cac03 
…#24419)

* Change nodes-by-type file extension from JS to TS

* Update reducer index import

* Update IDeleteNodeAction

* Update packages/gatsby/src/redux/reducers/nodes-by-type.ts

* properly handle undefined map.get usage

Co-authored-by: Michal Piechowiak <[email protected]>
Co-authored-by: gatsbybot <[email protected]>
Co-authored-by: Blaine Kasten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blainekasten blainekasten blainekasten approved these changes

@pieh pieh pieh left review comments

Assignees

@pieh pieh

@alisson-suzigan alisson-suzigan

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alisson-suzigan @pieh @blainekasten @LekoArts @gatsbybot