Use mutations in Gatsby Admin #23337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Handle default export case * heh * fix comment
* fix `gatsby-config` mention * chore: format Co-authored-by: gatsbybot <[email protected]>
* added details signifying that node fields can be arbitrary * Update docs/docs/data-fetching.md Co-Authored-By: Kyle Gill <[email protected]> * Update docs/docs/data-fetching.md Co-Authored-By: Kyle Gill <[email protected]> * removed empty line to fix failed linting tests Co-Authored-By: Kyle Gill <[email protected]> Co-authored-by: Kyle Gill <[email protected]>
* chore(sites): add new sites built by bejamas * chore(creators): update bejamas cover
Co-authored-by: Mario Nikolaus <[email protected]>
* fix(www): fix sidebar * Update sidebar.js
…nable e2e testing for resources (#23274) * fix(recipes): Fix shadow-file resource for scoped NPM packages * WILL SLASH FIX WINDOWS??? * Add missing code block * Try again * hmmm joinPath maybe is the problem * More fixes * try reenabling tests * disable colors in diffs * Fix npm script test * Why do these keep changing all the time?? * Use parsed value for the plan * Disable Chalk colors on unit tests so match local ones * Update packages/gatsby-recipes/src/providers/utils/get-diff.js Co-Authored-By: John Otander <[email protected]> Co-authored-by: John Otander <[email protected]> Co-authored-by: gatsbybot <[email protected]>
* chore(starters): add gatsby-starter-ecommerce * chore(starters): add gatsby-starter-ecommerce Co-authored-by: gatsbybot <[email protected]>
* Add site Interficie Internet Services * Correct JavaScript cammelcase * Prettier format Co-authored-by: Obinna Ekwuno <[email protected]> Co-authored-by: gatsbybot <[email protected]>
* fix remove local domain * fix local domain * fix local domain * fix remove local domain * fix for linter
* Create paul scanlon 100 days of Gatsby blog post and add assets * fix frontmatter * fix frontmatter issue and ad relative links * fix typos and spacing issues * Update docs/blog/2020-04-20-paulie-scanlons-journey-of-100-days/index.md Co-Authored-By: LB <[email protected]> Co-authored-by: Laurie Barth <[email protected]> Co-authored-by: LB <[email protected]>
The line (one line, two places) I'm editing was copied from a comment in #21627 without the surrounding context. This edit provides that context. Co-authored-by: gatsbybot <[email protected]>
* Add shreysachdeva.tech to sites.yml **Description** Added the details of my personal website shreysachdeva.tech. **Documentation** No documentation **Related Issues** N/A * chore: format Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Obinna Ekwuno <[email protected]>
…ng from first manifest icon (#23077) * Decouple favicons from manifest icons * Update packages/gatsby-plugin-manifest/README.md * Replace include_favicon undefined check with nullish coalescing operator Co-Authored-By: Alex Moon <[email protected]> * Assert gatsby-plugin-manifest generates favicon PNG (unless include_favicon option is false) * Don't mock createContentDigest in gatsby-plugin-manifest's gatsby-ssr tests (to be consistent with gatsby-node tests) * Tweak a comment Co-authored-by: LB <[email protected]> Co-authored-by: Alex Moon <[email protected]>
LekoArts
reviewed
Apr 21, 2020
LekoArts
reviewed
Apr 21, 2020
LekoArts
reviewed
Apr 21, 2020
Fixed typo in README.md
* Add Besoegsvenner site to showcase
50.000 elderly people in Denmark feel lonely. This project seeks to inform people to become visitor friends ("Besøgsven" in Danish) to help fight loneliness and bring new friendships in to the world.
* Update sites.yml
Co-authored-by: Obinna Ekwuno <[email protected]>
Co-authored-by: gatsbybot <[email protected]>
… data (#23242) * Add Drupal data updater script to update benchmark data * Remove console.log statement Co-authored-by: gatsbybot <[email protected]>
|
Thanks for the detailed review @ascorbic! 🙏 |
* Add null check to address #21263 #21263 is an issue many people are arriving at for a variety of reasons. Since the code contains this logic on the following line: ``` if (pageHeadings && pageHeadings.length) { ``` There should be no issue in seeing if `document.getElementById(`gatsby-focus-wrapper`) exists first before attempting to look up `getElementsByTagName`. * Update packages/gatsby/cache-dir/navigation.js Co-Authored-By: Vladimir Razuvaev <[email protected]> * chore: format Co-authored-by: Vladimir Razuvaev <[email protected]> Co-authored-by: gatsbybot <[email protected]>
|
Worked for me locally! |
|
It kinda worked for @laurieontech locally 😬 Only requires editing a gitignored bundle file and copying some node_modules... |
|
Haha it counts as working as long as the README tells you how to make it work...right? |
…Typscript (#22782) * Migrate remaining files in gatsby-cli/reporters/logger/ink to TS * Rename "IProps" to something more contextual Extend interface parameter individually instead of using utility * Clean up after merging the redux master changes Co-authored-by: Blaine Kasten <[email protected]>
* Add noop data update scripts for all CMS benchmarks * Add data update to remainder of benchmarks
Co-authored-by: Blaine Kasten <[email protected]>
* Add warning message for a long queries * Change timeout to 15 seconds * Replace console with report * Print out queryJob.componentPath instead of page.internalComponentName * Add new info in the warning message Co-authored-by: gatsbybot <[email protected]>
* refactor(inference-metadata): Convert to TypeScript * Remove unused variable * Forgot some types * refactor(type-conflict-reporter): Node description After tightening the original util function to return a string only, it seemed sensible to convert that to use nullish coalescing. At that point, seeing the function is only used in a single place and not exported, I inlined it. * refactor(inference-metadata): Interface renaming * fix: Extract ValueType type * refactor: Change type from unknown to object * Corrected types, but left the code alone * Removed redundant comments
… remark (#21188) * pass compiler to gatsby-remark-* plugins in the mdx plugin * make getImageCaption async * use async mdx compiler * fix for using compiler * don't mutate the node multiple times * convert markdown ast to html ast Co-authored-by: vladar
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin is alive! 🎉 This is adding mutation support from #23335 to Gatsby Admin (#23291) in order to make it possible to add and remove gatsby plugins—including editing the gatsby-config.js and installing/uninstalling the dependency!! 🔥