Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): update programmatically-creating-pages.md add missing shortcodes #23157

Merged
merged 2 commits into from
Apr 16, 2020
Merged

fix(docs): update programmatically-creating-pages.md add missing shortcodes #23157

merged 2 commits into from
Apr 16, 2020

Conversation

muescha
Copy link
Contributor

@muescha muescha commented Apr 16, 2020

Description

changes:

  • add missing line for shortcodes

Related Issues

Note

i see my prettier/linter removes comma? did i need some setup changes?
🤔

@muescha muescha requested a review from a team as a code owner April 16, 2020 00:04
@muescha muescha mentioned this pull request Apr 16, 2020
Merged
@muescha
Copy link
Contributor Author

muescha commented Apr 16, 2020

linting/prettier failed - i have to checkout how to fix it with my local repo

@muescha
Copy link
Contributor Author

muescha commented Apr 16, 2020 •
edited
Loading

removed the globally prettier <2.0 and reinstalled all deps to fix it...

vladar
vladar approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@vladar vladar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing the missing piece and fixing it!

@vladar vladar added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Apr 16, 2020
@gatsbybot gatsbybot merged commit 85f6d24 into gatsbyjs:master Apr 16, 2020
@muescha muescha deleted the muescha/fix/programatic-shortcodes branch April 17, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muescha @vladar @gatsbybot