Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gatsby): Convert query/utils to typescript #22171

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

kawamataryo
Copy link
Contributor

Description

Convert query/utils to typescript.

Related Issues

Related to #21995

blainekasten
blainekasten previously approved these changes Mar 11, 2020
Copy link
Contributor

@blainekasten blainekasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, let's merge it!

Thank you so much for contributing to our TypeScript refactor! We have more work to do and we would love to have you stay involved in our transition. Please submit more PRs! 💜

@blainekasten blainekasten added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 11, 2020
@blainekasten
Copy link
Contributor

Looks like tests are failing. If you fix them we should be able to merge!

@blainekasten blainekasten removed the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 11, 2020
@kawamataryo
Copy link
Contributor Author

@blainekasten

Hi. thank you for review. I fixed test.

@ascorbic ascorbic merged commit 099b4a0 into gatsbyjs:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants