chore(gatsby-core-utils): migrate to TypeScript #22040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkov
commented
Mar 7, 2020
| @@ -0,0 +1,22 @@ | |||
| import Module from "module" | |||
There was a problem hiding this comment.
"allowSyntheticDefaultImports": true is needed for this to work with import * as Module from "module"
|
Could you please create separate PRs for each file you change, like requested by @blainekasten in #21995 (comment)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate
gatsby-core-utilsto TypeScriptThis PR does not yet address all tests, due to some mocking being done with Jest in a way that's not favored by TypeScript. A good workaround would be to revisit the tests in another PR, separating each case where mocking is needed and providing a mock implementation inline.
Related Issues
Umbrella ticket: #21995
Overlapping changes: #22031