chore(gatsby): Convert cache.js to TypeScript #20626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
suggested changes
Jan 15, 2020
There was a problem hiding this comment.
I think the Cache should have a type parameter since all inputs/outputs are of the same type. If you type it on the methods then the same Cache instance could be called with different types and the types wouldn't mean much...
Am I wrong? Maybe it works a little different from Flow.
pvdz
previously approved these changes
Jan 15, 2020
ascorbic
commented
Jan 16, 2020
|
|
||
| beforeEach(() => { | ||
| manager.caching.mockReset() | ||
| fs.ensureDirSync.mockReset() | ||
| ;(manager.caching as jest.Mock).mockReset() |
There was a problem hiding this comment.
that's normal :) because else it could be a return function of mockReset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying again with #20622 to see if I can preserve history. This includes the changes to enable Jest to run on TypeScript files that were in #20457. It also has a couple of additions to tsconfig to reflect the fact we're running in Node not the browser
Documentation
n/a
Related Issues
#20457