chore: Update the screenshot Lambda function #20427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
reviewed
Jan 6, 2020
packages/gatsby-transformer-screenshot/lambda/__manual-tests__/local-test.js
Show resolved
Hide resolved
|
FYI: i got in mail the double-shot-2507 newsletter with:
maybe it is interesting for you how they designed the lambda screenshot tool |
sidharthachatterjee
approved these changes
Jan 8, 2020
sidharthachatterjee
added
the
bot: merge on green
9 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #19452. The errors were due to the Lambda container running out of space. It seems like this was due to the function being kept warm, and error logs filling up the tmp directory.
Redeploying the function would have reset that space, acting as a temporary fix. However, this function was running on Node 6, which is no longer supported by AWS Lambda. Meaning it has to use a newer runtime before it could be redeployed.
I tried and failed to rebuild the existing code on a newer version of Node.
Instead, here's an update that:
This PR drops 40MB from a shallow checkout of the Gatsby repo 🎉
The code has been running for the last couple of weeks creating the screenshots at https://www.gatsbyjs.org/showcase/.
Documentation
There are no changes to the plugin. This PR only updates the AWS Lambda function that the plugin uses, which is not a user-facing part of the plugin. I've added a readme to the Lambda function.
Related Issues
Fixes #19452