Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use createContentDigest helper #20239

Merged
merged 9 commits into from
Jan 8, 2020
Merged

chore: Use createContentDigest helper #20239

merged 9 commits into from
Jan 8, 2020

Conversation

sidharthachatterjee
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee commented Dec 20, 2019 •
edited
Loading

  • packages/gatsby-theme-blog-core/gatsby-node.js
  • packages/gatsby-source-contentful/src/normalize.js
  • packages/gatsby-plugin-mdx/gatsby/on-create-node.js
  • packages/gatsby-plugin-mdx/utils/create-fake-file-node.js

Fixes #8805

Paired with @kindavishal on a community pairing session! 🎉

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner December 20, 2019 10:13
@sidharthachatterjee sidharthachatterjee added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Dec 20, 2019
@sidharthachatterjee
Copy link
Contributor Author

sidharthachatterjee commented Dec 20, 2019 •
edited by kindavishal
Loading

  • Add gatsby-core-utils to dependencies where required

@muescha
Copy link
Contributor

muescha commented Dec 20, 2019

i remember the contentful was declined before #14567 but i think we should include it anyway to complete the issue...

@sidharthachatterjee
Copy link
Contributor Author

Yeah, I don’t think we should block this on any PRs anymore. Let’s wrap it up.

@muescha muescha mentioned this pull request Dec 20, 2019
Closed
@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner December 20, 2019 18:51
@kindavishal
Copy link
Contributor

Hey @sidharthachatterjee can you tell me what I am doing wrong here?

sidharthachatterjee
sidharthachatterjee commented Jan 8, 2020
View reviewed changes
Copy link
Contributor Author

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kindavishal Let's apply the suggestion and add gatsby-core-utils as a dependency for gatsby-theme-blog-core and gatsby-source-contentful

Should be good to go then!

packages/gatsby-source-contentful/src/normalize.js Outdated Show resolved Hide resolved
@kindavishal
Copy link
Contributor

kindavishal commented Jan 8, 2020 •
edited
Loading

All requirements should completed by now. Please let me know if I left anything or did something wrong somewhere.

@sidharthachatterjee
Copy link
Contributor Author

@kindavishal Need to add dependencies in package.json. See previous comment.

@sidharthachatterjee sidharthachatterjee merged commit ead08cc into master Jan 8, 2020
@sidharthachatterjee sidharthachatterjee deleted the fix/content-digest branch January 8, 2020 21:32
@janosh janosh mentioned this pull request Jan 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindavishal kindavishal kindavishal left review comments

Assignees

@kindavishal kindavishal

Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: update gatsby plugins to use new createContentDigest helper
3 participants
@sidharthachatterjee @muescha @kindavishal