-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Routing Doc and remove duplicate stub #19918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like an appropriate change to me! One thing worth noting is that docs getting renamed can break old links. Doing a global search of the repo, it looks like the old name isn't linked anywhere in our docs, but we often will use a createRedirect
in the gatsby-node
file to make sure that the any traffic to the old page (from old links on other's blog posts or wherever they might be scattered on the internet) doesn't end up in a 404.
Here's where they start:
Line 62 in 3d6bfee
createRedirect({ |
I'm not sure this page ever got enough traffic to need a redirect, but it probably wouldn't hurt either 🤷♂
Ooh good to know. I did the global search but didn't know about the redirect rule. Thanks Kyle! I'll add that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Good catch, @gillkyle!
Redir for stubshould be also there a redir for the stub? it is still in google for the exact phrase: Issue solvedis the issue #9779 (linked from stub) now solved? |
We don't typically redirect stubs, but given the SEO hit here that's a point well taken. Opened #20019 |
Description
This existing page can be more appropriately named to match its content. It's first header "Creating Dynamic Navigation in Gatsby" should be the page title, and the now redundant stub for "Rendering Sidebar Navigation Dynamically" can be removed.
Related Issues
Addresses #18993