docs: gatsby for apps - auth and client only routes #19551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillkyle
added
the
type: documentation
added 2 commits
November 15, 2019 17:52
gillkyle
changed the title
5 tasks
|
Lots of great stuff here @gillkyle! Think this is going to be an important addition to the docs. I'm considering whether we should change some of the headers or further break out the pages, but let me noodle on it a bit. Overall it's in really good shape. |
Co-Authored-By: LB <[email protected]> Co-Authored-By: Michael <[email protected]>
Co-Authored-By: LB <[email protected]>
laurieontech
previously approved these changes
Nov 20, 2019
Co-Authored-By: LB <[email protected]>
gillkyle
added
the
status: awaiting reviewer response
laurieontech
approved these changes
Nov 21, 2019
muescha
reviewed
Nov 23, 2019
Comment on lines
+1043
to
1060
| } else if (node.internal.type === `CreatorsYaml`) { | ||
| // Creator pages | ||
| const validTypes = { | ||
| individual: `people`, | ||
| agency: `agencies`, | ||
| company: `companies`, | ||
| } | ||
|
|
||
| if (!validTypes[node.type]) { | ||
| throw new Error( | ||
| `Creators must have a type of “individual”, “agency”, or “company”, but invalid type “${node.type}” was provided for ${node.name}.` | ||
| ) | ||
| } | ||
| slug = `/creators/${validTypes[node.type]}/${slugify(node.name, { | ||
| lower: true, | ||
| })}` | ||
| createNodeField({ node, name: `slug`, value: slug }) | ||
| } |
There was a problem hiding this comment.
this code block was removed in #19495 Remove creator showcase
we should remove it again?
This was referenced Nov 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is an incremental improvement for the recommendations made in #18993 for the Building Apps with Gatsby workflow.
The two main changes are in:
Rationale for Adjustments
The Adding Authentication guide mostly just related to the client only routes guide and linked out to the other guides, deferring to explain authentication to the other guides. To update that, I added a diagram about what happens to get authentication info from another service to give an overview on that page which seems like it should serve as more of an overview.
The Client-only Routes guide added more detail on why they are needed and how they are implemented. It also extended the diagrams on the overview page to show the hybrid style approach that an app with authentication requires.
Other small changes
The example for simple auth was updated a little bit, renaming some things and updating links back to the right doc.
Screenshots
Adding Authentication
Client-only Routes & User Authentication
Related Issues
Relates to #18993