Fix utils/develop path extension check to support location.search

[bvaughn]

This PR adds the ability to define a client-side route that properly supports a dynamic querystring (location.search) in development mode.

For example

exports.onCreatePage = async ({ page, boundActionCreators }) => {
  const { createPage } = boundActionCreators;

  return new Promise((resolve, reject) => {
    if (someCriteriaCheck) {
      page.matchPath = 'path.html:args?';

      createPage(page);
    }

    resolve();
  })
};

URL	Works before?	Works after?
localhost:8000/path.html	✓	✓
localhost:8000/path.html/foo	✓	✓
localhost:8000/path.html/?foo	✓	✓
localhost:8000/path.html?foo	✖	✓

More context available in this discussion thread.

I have not yet tested the production build of the Gatsby site I'm working on but I assume this will work there as-is. (If not I'll follow up with another PR.)

[gatsbybot]

Deploy preview ready!

Built with commit 3455ff9

https://deploy-preview-1844--using-drupal.netlify.com

[jquense]

extname.startsWith()? might be a bit clearer 😄

[bvaughn]

Okay 😛 I guess both are used in this project.

[jquense]

yeah, we are slowly trying reach some sort level consistency on that stuff. Thanks for the change, i realize it's small and a bit inane to have asked 🙇

[bvaughn]

Nah, it's a great goal. Thanks for pointing it out! 😄

[gatsbybot]

Deploy preview ready!

Built with commit 3455ff9

https://deploy-preview-1844--gatsbygram.netlify.com

[KyleAMathews]

So an alternative way to handle this I've been thinking is to just delete all html files from public when starting bootstrap. The reason this check is here is because without it, you'd load html from previous static builds and wonder why changes weren't hot reloading. If we just deleted all html then we could safely load any path in public as all html requests would be handled by webpack-dev-server.

[bvaughn]

That sounds reasonable.

It seems we could still merge this now and just remove it later if/when you decide to do that though? It would fix a current bug / pain point and it wouldn't (I don't think) cause any regression or negative side effect.

[KyleAMathews]

Ah nvm, deleting all html files solves a different problem :-) Merging! Thanks for the PR!

[bvaughn]

aww yasssss 🕺