-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Russian translation #17840
Init Russian translation #17840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings @alexandrtovmach thank you for jumping in and start the Russian translation, this is so exciting! 💪
I just checked all the 23 files and they're all MD
files related to the tutorial which is good, (I think this would be one of the starting points for the translations, waiting on official here), and checked the index.md
and looks good on structure, few comments here:
- You'd want someone else from Russian language to take a look at this, it's not that is bad, but I don't know Russian hehe and it's always good for someone else to check your work to see missing punctuations or bad word spelling, for example in Spanish we (I) miss a lot of accents and so on 💪
- It'd be nice to only have the English copy and paste here, and then start translating so it's easier to compare side to side the changes on Github, this is something that we spoke in the another PR for spanish because it's easier for maintainers to check correct line numbers and side to side translation, English and Russian.
- One last detail about the
index.md
and comes from the item above, I checked against the original and all line numbers match which is good, but I think you erased line40
which is a blank line, but you should keep that line to avoid future merge conflicts 👍
Besides that I think is good to go for me, but I'd love to check on @tesseralis thoughts here on how to continue from here 🚀 Nice work 🥇
|
||
Есть много вариантов использования Gatsby и не все из них затрагиваются в основных руководствах, чтобы сосредоточить тебя во время обучения. Раздел "Дополнительные руководства Gatsby" представляет собой набор ресурсов о более широком спектре задач Gatsby, например плагины для изображений и работа с CMS. | ||
|
||
Изучай больше с ["дополнительными руководствами Gatsby"](/tutorial/additional-tutorials/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Изучай больше с ["дополнительными руководствами Gatsby"](/tutorial/additional-tutorials/). | |
Изучай больше с ["дополнительными руководствами Gatsby"](/tutorial/additional-tutorials/). | |
This should have a line 40
in blank like this to match the original file 40 lines 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Darking360 Thanks for review.
|
Hey @alexandrtovmach cool! About the lines it's true, sorry for that, just checked on the Spanish PR and that happened as well there, so it's good, it's because of Github that does not show that last line 🤔 Let's see what it's the decision about the original versions in English but this looks really good! Thank you 🚀 |
@alexandrtovmach nice work 💪 , but so what are the next steps? Wait for response from @tesseralis? |
@lex111 Seems like that |
@alexandrtovmach @lex111 I've decided that it's best to change approaches to using separate repos for each translation, and created a russian repo here and made you two codeowners: https://github.com/gatsbyjs/gatsby-ru/tree/master @alexandrtovmach, could you re-open this pull request in that repo? I'll add more instructions soon, but this should get you unblocked. |
@tesseralis Isn't it better to create translation teams, as in React? Then in CODEOWNERS you can specify only the team name. |
@tesseralis Thank you👍 sounds great 🔥🔥 |
@lex111 I think it will be added in near future, for now it's enough to have a separate repositories to unblock translation process. Let's go to this new repo and discuss about plan of translation |
@lex111 The problem with GitHub teams is that it's not visible to people not in the organization and only an organization admin can change membership. With CODEOWNERS, the repo maintainers can just add and remove people themselves. |
@alexandrtovmach do you have anyone else that can help you maintain the Ukrainian translation? For React we wanted at least two people to act as a check and balances and I think we'd like the same thing for Gatsby. |
@tesseralis but will GitHub teams be created anyway? In React, they were used to communicate between maintainers and to inform all translators. |
@lex111 I think we're going to use the Gatsby discord for that. To my impression it didn't seem that most teams used them, and I ended up making announcements on Slack instead. |
@tesseralis GH teams are convenient in that they are immediately tied to all the maintainers, and not everyone will be registered in Slack/Discord, all the more you will receive an email notification when you mention the team, this is very convenient when code reviewing! |
@tesseralis Currently, I haven't someone for Ukrainian team, but I think they can join later. |
Description
Initial Russian translation for playing with a structure.
/docs/tutorial -> /translations/ru/tutorial
/translations/ru/tutorial/index.md
Related Issues
RFC: gatsbyjs/rfcs#42
PR with Spanish translation (contain small discussion): #17779