Bugfix : gatsby-source-wordpress giving invalid node names to GraphQL #1778
Conversation
Modified regex validating node names. #1774 This could be in cause, we surely need a better validation of names from GraphQL because `/^[_a-zA-Z][_a-zA-Z0-9]*$/` see as valid some names that will break later on : graphql/graphql-js#632 `building schemaName "__jetpack_v4" must not begin with "__", which is reserved by GraphQL introspection. In a future release of graphql this will become a hard error.`
sebastienfi
changed the title
|
Deploy preview ready! Built with commit 98dbdea |
|
Deploy preview ready! Built with commit 98dbdea |
| colorized.out( | ||
| `=START PLUGIN=====================================`, | ||
| colorized.color.Font.FgBlue | ||
| if (_verbose) console.log() |
There was a problem hiding this comment.
plugins are now passed a reporter object for doing this, if you want to make use of it. e.g. reporter.verbose('blah')
There was a problem hiding this comment.
@jquense it'd be cool to auto-prefix the plugin name as well to messages
| if (!NAME_RX.test(nkey)) { | ||
| nkey = `_${nkey}`.replace(/-/g, `_`).replace(/:/g, `_`) | ||
| if (!NAME_RX.test(nkey) || restrictedNodeFields.includes(nkey)) { | ||
| nkey = `${conflictFieldPrefix}${nkey}`.replace(/-|__|:|\.|\s/g, `_`) |
There was a problem hiding this comment.
so we should provide a single robust utility for doing this (there is one in gatsby), but this is still incomplete in terms of what graphql will allow. It needs to replace any character that isn't alphanumeric or a _. It also can't start with a number or two or more _. e.g here are some fields that would still error out here.
- "##foo"
- "1number"
|
Is this the problem I'm experiencing in #1321 (comment) ? |
Should solve #1774
console.log()to bring a quieter terminal at build, keeping only necessary info (we still need to see that the process did not hang on heavy sites).@jquense
We surely need a better validation of names from GraphQL because
/^[_a-zA-Z][_a-zA-Z0-9]*$/see as valid some names that will break later on : graphql/graphql-js#632Example :
building schemaName "__jetpack_v4" must not begin with "__", which is reserved by GraphQL introspection. In a future release of graphql this will become a hard error.