Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update sharp to be node 12 compatible #13702

Closed
wants to merge 1 commit into from
Closed

chore: update sharp to be node 12 compatible #13702

wants to merge 1 commit into from

Conversation

moonmeister
Copy link
Contributor

@moonmeister moonmeister commented Apr 29, 2019 •
edited
Loading

Description

Node 12 builds are failing due to node sharp version not being node 12 compatible. This PR updates sharp to the current version that has node 12 support. It should still have node 6 support (tests will confirm).

Related Issues

#13700

@moonmeister moonmeister added the type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change label Apr 29, 2019
@moonmeister
Copy link
Contributor Author

Example build error: https://circleci.com/gh/gatsbyjs/gatsby/116910?utm_campaign=workflow-failed&utm_medium=email&utm_source=notification

@pieh
Copy link
Contributor

pieh commented Apr 29, 2019

This is duplicate of #13646 - there is something that we need to fix before merging - see description for revert we did some time ago ( #13271 (

@moonmeister moonmeister deleted the sharp-update branch April 29, 2019 11:48
@DSchau DSchau mentioned this pull request Apr 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonmeister @pieh