sass-integration #109
sass-integration #109
Conversation
… enable .scss extensions / linted ok
|
I figured that there is no harm in including sass plus I'm sure a lot of people will appreciate this down the line. |
| examples/biz-website/public/ | ||
| examples/blog/public/ | ||
| *.un~ | ||
|
|
||
| # IDEA/WebStorm configuration directory | ||
| .idea/ |
There was a problem hiding this comment.
Shouldn't this be added to the .gitignore?
There was a problem hiding this comment.
I'm not sure, I usually don't include it as not to pollute the project with unnecessary IDE configuration files
There was a problem hiding this comment.
This is the npm ignore file not .gitignore.
There was a problem hiding this comment.
ohh good catch, I feel silly, let me quickly fix it.
|
👍 yeah, I agree popular Webpack loaders should be added to Gatsby so things just work out of the box for the vast majority of people. I.e. add more from here https://www.npmjs.com/browse/keyword/webpack-loader |
|
You are correct, along with .scss, there should also be .sass . I'll correct it and resubmit shortly. |
|
At this point you can merge this if you like. |
|
Why is there 3 configs? |
|
3 configs? I'm not sure I understand what you mean, but that's how I've always done it. |
|
Oh... nvm :) I forgot that there's a config for each stage. Didn't look at the file in full. |
| @@ -1,30 +0,0 @@ | |||
| # Logs | |||
There was a problem hiding this comment.
Could you restore this file.
|
I think once the |
|
I've tried to squash my commits but I'm not entirely convinced that I've been successful at it. ;( |
|
:) Try following this tutorial: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit |
|
I've re-submitted cleaned-up version on #110 |
Added a start script to package.json
sass-loader & node-sass modules added / webpack.config.js modified to enable .scss extensions / linted ok