Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(www): use full starter repo name for screenshot alt text #10695

Merged
merged 3 commits into from
Dec 28, 2018
Merged

fix(www): use full starter repo name for screenshot alt text #10695

merged 3 commits into from
Dec 28, 2018

Conversation

lwz7512
Copy link
Contributor

@lwz7512 lwz7512 commented Dec 28, 2018

Description

Hi, buddies, there are two small problems in Starter Library | GatsbyJS site page, starter name can not be rightly navigated to its page, showing Page not found... so, I fixed it, please review! thank u!

Related Issues

no

@lwz7512 lwz7512 requested a review from a team as a code owner December 28, 2018 00:38
@pieh pieh changed the title fix starter-list comp for wrong nav... fix(www): use full starter repo name for screenshot alt text Dec 28, 2018
@pieh
Copy link
Contributor

pieh commented Dec 28, 2018

I've merged #10665 which was fixing navigation link on title and adjusted this one to fix the screenshot alt text

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lwz7512!

@pieh pieh merged commit 23c5b1f into gatsbyjs:master Dec 28, 2018
@lwz7512
Copy link
Contributor Author

lwz7512 commented Dec 28, 2018

@pieh you're welcome!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants