Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gatsby): update internal-data-bridge plugin to use createContentDigest #10471

Merged
merged 1 commit into from
Dec 20, 2018
Merged

refactor(gatsby): update internal-data-bridge plugin to use createContentDigest #10471

merged 1 commit into from
Dec 20, 2018

Conversation

smurrayatwork
Copy link
Contributor

This updates gatsby's internal-data-bridge plugin to use createContentDigest, as requested by #8805.

First time gatsby contributor here! I was unsure as to how to add tests to this particular plugin, as I didn't see any for the other internal plugins either.

@smurrayatwork smurrayatwork requested a review from a team as a code owner December 14, 2018 17:17
@pieh
Copy link
Contributor

pieh commented Dec 20, 2018

Tests for this are tricky, especially one for updating Site nodes. I don't love it, but let's merge You PR as-is. I verified it works locally.

@pieh pieh changed the title Updates internal-data-bridge plugin to use createContentDigest. chore(gatsby): update internal-data-bridge plugin to use createContentDigest Dec 20, 2018
@pieh pieh changed the title chore(gatsby): update internal-data-bridge plugin to use createContentDigest refactor(gatsby): update internal-data-bridge plugin to use createContentDigest Dec 20, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smurrayatwork!

@pieh pieh merged commit 6c8f8f8 into gatsbyjs:master Dec 20, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 20, 2018

Holy buckets, @smurrayatwork — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants