feat(gatsby-plugin-manifest): don't output theme-color if it's not defiened

[DZuz14]

Not really sure how I go about submitting a PR here. This addition references issue #9977

Any guidance would be greatly appreciated.

[pieh]

This looks reasonable - maybe small code change so it's easier to read what it does.

Another thing - can you remove changes in packages/gatsby-source-faker/README.md?

[pieh]

Can we prep headComponents array ahead of time to avoid concat with ternary operator inside it?

const headComponents = [
  <link
    key={`gatsby-plugin-manifest-link`}
    rel="manifest"
    href={withPrefix(`/manifest.webmanifest`)}
  />,
]

if (pluginOptions.theme_color) {
  headComponents.push(
    <meta
      key={`gatsby-plugin-manifest-meta`}
      name="theme-color"
      content={pluginOptions.theme_color}
    />
  )
}

setHeadComponents(headComponents)

[DZuz14]

Yeah, I thought I got rid of those changes to that ReadMe. I am not even sure how they got changed to be honest. Dog stepping on keyboard perhaps lol.

[DZuz14]

Is it alright that I created the headComponents array at the top of the function, and changed the other conditionals to just add to this array as we step through the function? I think this makes it pretty legible and easy to understand whats going on. I ran the tests after this change and everything still seems to work just fine.

[pieh]

Oh, yeah, that's fine too 👍

[pieh]

Hmm, actually this README changes (that your dog committed 🤣 ) seems like something very weird is happening and I get them locally too, I'll just merge with those - hopefully this will fix problems lol

[gatsbot]

Holy buckets, @DZuz14 — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

[pieh]

published [email protected]