-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't re render on hash anchors from markdown wrapper #462
Comments
Oh? Didn't realize this. How do you stop the rerender? Some react-router config? |
related: #386 |
What about https://github.com/adjohnson916/anchorate? (I see @ivanoats already pointed to this in the #386) |
@KyleAMathews a naive way could be to intercept links with document.querySelector(`#${something}`).scrollIntoView(); |
that could be followed up with: window.history.pushState(null, null, `#${something}`); However, the back button does not seem to work as expected |
I think this issue was being faced by Phenomic as well taion/react-router-scroll#37 The behavior I am seeing is the same as mentioned in the issue above |
On not re-rendering, just was investigating this — easiest solution is to add a |
This should be set by default. Markdown headings usually have anchor hashes. The component gets re-rendered if the hash link is clicked.
The text was updated successfully, but these errors were encountered: