-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap routes with sCU that that does shallow compare check + blocks renders on hash changes #487
Comments
Wasn't this resolved with #467? |
No — that just fixed react-router-scroll from storing extra scroll positions. The extra renders are still happening cause react-router pushes out location changes to the active routes. |
oh! hmm yes missed this since I was using |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed due to inactivity. |
I'm encountering a problem with |
Could this be done with |
@ralphstodomingo what version of Gatsby are you on? |
Also, rendering on hash changes is normally what people would want I believe. If you don't want that, implement shouldComponentRender in your page component and return false when only the hash changes. |
Due to the high volume of issues, we're closing out older ones without recent activity. Please open a new issue if you need help! |
#462 (comment)
The text was updated successfully, but these errors were encountered: