Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap routes with sCU that that does shallow compare check + blocks renders on hash changes #487

Closed
KyleAMathews opened this issue Oct 5, 2016 · 10 comments

Comments

@KyleAMathews
Copy link
Contributor

#462 (comment)

@KyleAMathews KyleAMathews changed the title Wrap routes with sCU that that does swallow check + blocks renders on hash changes Wrap routes with sCU that that does shallow compare check + blocks renders on hash changes Oct 5, 2016
@f0rr0
Copy link

f0rr0 commented Oct 5, 2016

Wasn't this resolved with #467?

@KyleAMathews
Copy link
Contributor Author

No — that just fixed react-router-scroll from storing extra scroll positions. The extra renders are still happening cause react-router pushes out location changes to the active routes.

@f0rr0
Copy link

f0rr0 commented Oct 5, 2016

oh! hmm yes missed this since I was using catch-links

@stale
Copy link

stale bot commented Oct 22, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Oct 22, 2017
@stale
Copy link

stale bot commented Nov 7, 2017

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Nov 7, 2017
@ghost
Copy link

ghost commented Feb 19, 2018

I'm encountering a problem with smooth-anchorate: that library is fine, the problem is that, on hash location changes, my page rerenders.
Any updates on this? If none, any hints on where I can tackle this in the codebase?

@m-allanson m-allanson reopened this Feb 19, 2018
@stale stale bot removed the stale? Issue that may be closed soon due to the original author not responding any more. label Feb 19, 2018
@m-allanson
Copy link
Contributor

Could this be done with replaceRouterComponent?

@KyleAMathews
Copy link
Contributor Author

@ralphstodomingo what version of Gatsby are you on?

@KyleAMathews
Copy link
Contributor Author

Also, rendering on hash changes is normally what people would want I believe. If you don't want that, implement shouldComponentRender in your page component and return false when only the hash changes.

@KyleAMathews
Copy link
Contributor Author

Due to the high volume of issues, we're closing out older ones without recent activity. Please open a new issue if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants