Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change react-helmet to react-helmet-async #208

Closed
wants to merge 1 commit into from
Closed

Change react-helmet to react-helmet-async #208

wants to merge 1 commit into from

Conversation

jthcast
Copy link

@jthcast jthcast commented Dec 26, 2020

react-helmet has causing below console error:

Warning: Using UNSAFE_componentWillMount in strict mode is not recommended and may indicate bugs in your code. See https://fb.me/react-unsafe-component-lifecycles for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.

Please update the following components: SideEffect(NullComponent)

Please check this issue nfl/react-helmet#548.
And react-helmet has async issue too. of course gatsby is not SSR framework but has problem potential.
react-helmet-async is solved this problem and gatsby has gatsby-plugin-react-helmet-asnyc.

what about change react-helmet to react-helmet-async?

@gatsbot gatsbot bot closed this Dec 26, 2020
@gatsbot
Copy link

gatsbot bot commented Dec 26, 2020

Hey, @jthcast

Thank you for your pull request!

This repo is now a read-only repo that's synced from the main Gatsby monorepo at https://github.com/gatsbyjs/gatsby/.

We've moved all our starters to https://github.com/gatsbyjs/gatsby/tree/master/starters so changes to starters are made there.

Please checkout our contribution docs & recreate your PR against the starter directory in monorepo.

https://www.gatsbyjs.org/contributing/how-to-open-a-pull-request/

Thanks again!

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant