Remove lock icon for runtime config overrides

- Remove the lock icon from the fixed property icon in the qwc-configuration.js file - Remove the lock icon for config values that are overridable at runtime in the config.html file - Fixes quarkusio#32229
gastaldi · Mar 29, 2023 · 75b04d1 · 75b04d1
1 parent 5ec91a9
commit 75b04d1
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 17 deletions.
diff --git a/...ttp/deployment/src/main/resources/dev-templates/io.quarkus.quarkus-vertx-http/config.html b/...ttp/deployment/src/main/resources/dev-templates/io.quarkus.quarkus-vertx-http/config.html
@@ -419,8 +419,6 @@
                         <td class="filterableConfigKey">
                             {#if item.configPhase?? && (item.configPhase == "BUILD_AND_RUN_TIME_FIXED" || item.configPhase == "BUILD_TIME")}
                             <i class="fas fa-lock" data-toggle="tooltip" data-placement="top" title="Fixed at build time (not overridable at runtime)"></i>
-                            {#else}
-                            <i class="fas fa-lock-open text-white" data-placement="top" title="Overridable at runtime"></i>
                             {/if}
 
                             {item.configValue.name}

diff --git a/extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-configuration.js b/extensions/vertx-http/dev-ui-resources/src/main/resources/dev-ui/qwc/qwc-configuration.js
@@ -63,15 +63,6 @@ export class QwcConfiguration extends LitElement {
         cursor: pointer;
         color: var(--lumo-primary-color);
       }
-      
-      .lock-icon {
-        color: var(--lumo-error-color-50pct);
-        font-size: small;
-      }
-      .unlock-icon {
-        color: var(--lumo-success-color-50pct);
-        font-size: small;
-      }
     `;
 
     static properties = {
@@ -158,12 +149,6 @@ export class QwcConfiguration extends LitElement {
                 <vaadin-tooltip for="icon-lock-${prop.name}" text="Fixed at build time (not overridable at runtime)"
                                 position="top-start"></vaadin-tooltip>
             `
-        } else {
-            return html`
-                <vaadin-icon theme="small" class="unlock-icon" id="icon-lock-${prop.name}" icon="font-awesome-solid:lock-open"></vaadin-icon>
-                <vaadin-tooltip for="icon-lock-${prop.name}" text="Overridable at runtime"
-                                position="top-start"></vaadin-tooltip>
-            `
         }
     }