Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject update that doesnt provide new info #844

Merged
merged 5 commits into from
Nov 30, 2024

revert changes to pallet vesting

42f3ddc
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Reject update that doesnt provide new info #844

revert changes to pallet vesting
42f3ddc
Select commit
Loading
Failed to load commit list.
GitHub Actions / E2E report yarn test-maintenance failed Nov 30, 2024 in 1s

E2E report yarn test-maintenance ❌

Tests failed

❌ e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

25 tests were completed in 846s with 19 passed, 6 failed and 0 skipped.

Test suite Passed Failed Skipped Time
test/sequential/maintenance-pallet.api.rolldown.test.ts 16✅ 642s
test/sequential/xyk-pallet.api.maintenance-config.test.ts 2✅ 1❌ 132s
test/sequential/xyk-pallet.api.maintenance-rules.test.ts 1✅ 5❌ 72s

✅ test/sequential/maintenance-pallet.api.rolldown.test.ts

On [mm] - regular l1 updates must be forbidden › On [%s] - regular l1 updates must be forbidden
  ✅ updateL2fromL1 operation is not allowed in mm
  ✅ withdraw operation is not allowed in mm
  ✅ cancelRequestsFromL1 operation is not allowed in mm
  ✅ forceCancelRequestsFromL1 operation is not allowed in mm
  ✅ forceUpdateL2fromL1 operation is not allowed in mm
  ✅ sequencerSetup operations are allowed in mm
  ✅ sequencerTearDown operations are allowed in mm
  ✅ Update is blocked on maintenance mode but works on upgradeability
On [upgradabilityMm] - regular l1 updates must be forbidden › On [%s] - regular l1 updates must be forbidden
  ✅ updateL2fromL1 operation is not allowed in mm
  ✅ withdraw operation is not allowed in mm
  ✅ cancelRequestsFromL1 operation is not allowed in mm
  ✅ forceCancelRequestsFromL1 operation is not allowed in mm
  ✅ forceUpdateL2fromL1 operation is not allowed in mm
  ✅ sequencerSetup operations are allowed in mm
  ✅ sequencerTearDown operations are allowed in mm
  ✅ Update is blocked on maintenance mode but works on upgradeability

❌ test/sequential/xyk-pallet.api.maintenance-config.test.ts

✅ maintenance- try to change Maintenance Mode with a non-foundation account THEN it failed
✅ check UpgradabilityOn can only be set after MaintenanceModeOn is set and MaintenanceMode works without UpgradabilityOn
❌ maintenance- check we can sell MGX tokens and compoundRewards THEN switch maintenanceMode to on, repeat the operation and receive error
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')

❌ test/sequential/xyk-pallet.api.maintenance-rules.test.ts

On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed
  ❌ multiswapSellAsset operation is not allowed in mm
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
  ❌ multiswapBuyAsset operation is not allowed in mm
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
  ❌ sellAsset operation is not allowed in mm
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
  ❌ buyAsset operation is not allowed in mm
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
  ❌ provideLiquidity operation is not allowed in mm
	TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
On Maintenance mode - aggregators and candidates are allowed
  ✅ Join as candidate , Aggregate metadata and update CandidateAgg runs on Mm

Annotations

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-config.test.ts ► maintenance- check we can sell MGX tokens and compoundRewards THEN switch maintenanceMode to on, repeat the operation and receive error 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/node_modules/gasp-sdk/index.js:4648:25)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-rules.test.ts ► On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed ► multiswapSellAsset operation is not allowed in mm 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at Function.multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/xyk.ts:82:23)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:61:31
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-rules.test.ts ► On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed ► multiswapBuyAsset operation is not allowed in mm 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at Function.multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/xyk.ts:82:23)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:61:31
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-rules.test.ts ► On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed ► sellAsset operation is not allowed in mm 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at Function.multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/xyk.ts:82:23)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:61:31
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-rules.test.ts ► On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed ► buyAsset operation is not allowed in mm 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at Function.multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/xyk.ts:82:23)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:61:31
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Check failure on line 0 in e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml

See this annotation in the file changed.

@github-actions github-actions / E2E report yarn test-maintenance

test/sequential/xyk-pallet.api.maintenance-rules.test.ts ► On Maintenance mode - multiSwaps / swaps / compound / prov liq are not allowed ► provideLiquidity operation is not allowed in mm 

Failed test found in:
  e2eTests/reports/junit.xml-ad8d0020-aeb4-11ef-a760-b14c9e8e8590.xml
Error:
  TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
Raw output 
TypeError: Cannot read properties of undefined (reading 'multiswapSellAsset')
    at Function.multiswapSellAsset (/home/runner/_work/mangata-node/mangata-node/e2eTests/utils/xyk.ts:82:23)
    at /home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:61:31
    at Generator.next (<anonymous>)
    at fulfilled (/home/runner/_work/mangata-node/mangata-node/e2eTests/test/sequential/xyk-pallet.api.maintenance-rules.test.ts:4:58)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
View more details on GitHub Actions