Eth rollup develop solo seq mod #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszaaa
reviewed
Mar 21, 2024
rollup/node/src/chain_spec.rs
Outdated
| } else { | ||
| Default::default() | ||
| }, | ||
| }, | ||
| // Use sequncer staking genesis config - this is intended only for testing |
There was a problem hiding this comment.
Suggested change
| // Use sequncer staking genesis config - this is intended only for testing | |
| // Use sequencer staking genesis config - this is intended only for testing |
| @@ -184,6 +184,10 @@ impl ExtBuilder { | |||
| MockSequencerStakingProviderApi::is_active_sequencer_context(); | |||
| is_liquidity_token_mock.expect().return_const(true); | |||
|
|
|||
| let is_selected_sequencer_mock = | |||
rollup/node/src/chain_spec.rs
Outdated
| } else { | ||
| Default::default() | ||
| }, | ||
| }, | ||
| // Use sequncer staking genesis config - this is intended only for testing | ||
| rolldown: rollup_runtime::RolldownConfig { sequencers: vec![] }, |
There was a problem hiding this comment.
how about just removing genesis config for rolldown.
then in test instead of initializing genesis config with inital sequencers, we could just call
Pallet::<T>::new_sequencer_active(s);
instead?
There was a problem hiding this comment.
There was a problem hiding this comment.
This is what I was about to do when I realized that there's https://github.com/mangata-finance/mangata-node/blob/b5ab95aedf52dabbe292b0083dfdbba1bc7f8d7a/pallets/rolldown/src/lib.rs#L276
so we're gonna need a genesis config anyway (you could set that as the storage default value and get rid of that, but that might get a little confusing for someone reading the code)
goncer
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.