Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rpc verify error #708

Merged
merged 2 commits into from
Mar 7, 2024
Merged

fix: rpc verify error #708

merged 2 commits into from
Mar 7, 2024

Conversation

devdanco
Copy link
Member

@devdanco devdanco commented Mar 6, 2024

No description provided.

@devdanco devdanco requested a review from mateuszaaa March 6, 2024 13:15
@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 51.79%. Comparing base (df7271b) to head (867df8d).

Files Patch % Lines
pallets/rolldown/rpc/src/lib.rs 0.00% 12 Missing ⚠️
Additional details and impacted files 
@@                  Coverage Diff                   @@
##           eth-rollup-develop     #708      +/-   ##
======================================================
- Coverage               51.83%   51.79%   -0.05%     
======================================================
  Files                      44       44              
  Lines                    7421     7428       +7     
======================================================
  Hits                     3847     3847              
- Misses                   3574     3581       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mateuszaaa
mateuszaaa approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@mateuszaaa mateuszaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tenequm
tenequm approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tenequm tenequm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devdanco devdanco merged commit 3f6e342 into eth-rollup-develop Mar 7, 2024
48 of 50 checks passed
@devdanco devdanco deleted the fix/rpc-verify-error branch March 7, 2024 13:47
@mateuszaaa mateuszaaa mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenequm tenequm tenequm approved these changes

@mateuszaaa mateuszaaa mateuszaaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devdanco @mateuszaaa @tenequm